[haiku-bugs] Re: [Haiku] #10040: [Tracker] shows packagefs volumes in Desktop menu
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Fri, 14 Nov 2014 06:34:09 -0000
#10040: [Tracker] shows packagefs volumes in Desktop menu
----------------------------+----------------------------
Reporter: jessicah | Owner: nobody
Type: bug | Status: assigned
Priority: normal | Milestone: R1
Component: File Systems | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 10849, 11450
Has a Patch: 1 | Platform: All
----------------------------+----------------------------
Comment (by bonefish):
Replying to [comment:13 jessicah]:
> I still think removing the B_FS_IS_PERSISTENT flag is the right way to
go. The arguments against it really don't hold that much water, and would
introduce a series of needless and ultimately ugly hacks.
>
> Another case to support removing the B_FS_IS_PERSISTENT flag is if you
boot Haiku from a different volume, the entire directory hierarchy when
booted from the previous volume doesn't exist any more.
The same could be said for a BFS image. If you don't mount it, its
contents isn't visible. Or the other way around: If you mount the
packagefs on another volume, everything is there again. So packagefs could
be considered virtual but it certainly is not volatile. A dedicated RAM FS
volume would definitely be both virtual and volatile, but one would still
want to have it appear as a volume in Tracker. OTOH, if we implemented a
life CD such that RAM FS instances were mounted where writable directories
are expected (settings, var, etc.), we would not want them to appear in
Tracker as separate volumes.
To sum it up: The way Tracker uses the `B_FS_IS_PERSISTENT` flag doesn't
have much to do with the actual kind of the file system and one may even
want different instances of the same file system behave differently.
Anyway, I'm not opposed to (re-)defining the semantics of
`B_FS_IS_PERSISTENT` as "shall appear as a volume in Tracker" and removing
the flag in packagefs.
> And as for querying, Axel's idea of including mount points within a
volume (if they can be queried, such as packagefs is) would properly
resolve the issue that the change mentioned in comment:3 was intended to
fix, and gives behaviour that is also logical.
>
> Any hints on where to look for adding support for passing a query on to
nested volumes?
I'm not a Tracker expert, but the `QueryEntryListCollection` constructor
(in QueryPoseView.cpp) looks like the place.
--
Ticket URL: <https://dev.haiku-os.org/ticket/10040#comment:14>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
