[haiku-bugs] Re: [Haiku] #10410: WebPositive: Javascript console
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Thu, 20 Mar 2014 07:42:16 -0000
#10410: WebPositive: Javascript console
----------------------------------------+----------------------------
Reporter: pulkomandy | Owner: pulkomandy
Type: enhancement | Status: new
Priority: low | Milestone: Unscheduled
Component: Applications/WebPositive | Version: R1/Development
Resolution: | Keywords: gsoc2014
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------------+----------------------------
Comment (by pulkomandy):
You now have some style violations:
* One line is over 80 columns in ConsoleWindow.cpp
* Always two blank lines between top-level blocks: two methods
definitions, includes and forward declarations, forward declarations and
class definition, etc. (you have only one most of the time, and up to 3)
* The members of ConsoleWindow class should be indented like the method
declarations (in the .h file)
* ConsoleWindow.h is missing a forward declaration of BButton
* "final" is a keyword in C++11, and you use it as a variable name in
ConsoleWindow::MessageReceived()
https://www.haiku-os.org/development/coding-guidelines
--
Ticket URL: <https://dev.haiku-os.org/ticket/10410#comment:6>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
