[haiku-bugs] Re: [Haiku] #10435: Problems updating type information for app binaries if a corresponding package exists
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Sun, 19 Jan 2014 15:38:51 -0000
#10435: Problems updating type information for app binaries if a corresponding
package exists
---------------------------------+----------------------------
Reporter: anevilyak | Owner: bonefish
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Servers/registrar | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
---------------------------------+----------------------------
Comment (by bonefish):
Replying to [comment:2 anevilyak]:
> +1. On a related note regarding MimeInfoUpdater::Do(), a question about
the conditional block [http://cgit.haiku-
os.org/haiku/tree/src/kits/storage/mime/MimeInfoUpdater.cpp#n132 here:] Do
you know if it's intentional that all those potential failures are
suppressed? Currently, if anyone of those fails, none of the encapsulated
update operations will wind up actually taking place, but the caller will
have no way of detecting it.
I don't see a reason why the errors are suppressed in this case, so I
guess the subconditions should simply be replaced by `(err = ...) ==
B_OK`. I suppose a reason for the somewhat inconsistent error handling
might be that the API (`update_mime_info()`) supports recursive operation
without any actual control over the recursion or possible handling of
errors. E.g. if some file has an incorrect (application) MIME type, the
whole recursive operation fails without providing the caller any
information about what happened where.
--
Ticket URL: <http://dev.haiku-os.org/ticket/10435#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
