[haiku-bugs] Re: [Haiku] #10494: [packagefs] page fault during mount
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Sat, 01 Feb 2014 13:17:52 -0000
#10494: [packagefs] page fault during mount
-----------------------------+----------------------------
Reporter: anevilyak | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: System/Kernel | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
-----------------------------+----------------------------
Changes (by bonefish):
* owner: bonefish => axeld
* component: File Systems/packagefs => System/Kernel
Comment:
This looks an issue with the driver settings implementation. The packagefs
code is pretty straight forward: It gets a driver settings handle via
[http://cgit.haiku-os.org/haiku/tree/src/add-
ons/kernel/file_systems/packagefs/volume/Volume.cpp#n423
parse_driver_settings_string()] and uses an [http://cgit.haiku-
os.org/haiku/tree/src/add-
ons/kernel/file_systems/packagefs/volume/Volume.cpp#n434 auto deleter] to
destroy it. The implementation of [http://cgit.haiku-
os.org/haiku/tree/src/system/libroot/os/driver_settings.cpp#n681
unload_driver_settings()] doesn't look right. `settings_handle::ref_count`
isn't initialized by `parse_driver_settings_string()` and the two
alternatives of either removing the settings from the list (which should
only contain actual driver settings) or not freeing them at all doesn't
seem right anyway.
--
Ticket URL: <https://dev.haiku-os.org/ticket/10494#comment:2>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
