[haiku-bugs] Re: [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.
- From: "jessicah" <trac@xxxxxxxxxxxx>
- Date: Fri, 14 Nov 2014 02:50:55 -0000
#11394: [PATCHes] BToolbar rework, standard icons, etc.
----------------------------------+----------------------------
Reporter: waddlesplash | Owner: axeld
Type: bug | Status: new
Priority: low | Milestone: Unscheduled
Component: Kits/Interface Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------+----------------------------
Comment (by jessicah):
I'm not completely confident reviewing this one. I'd rather see the likes
of stippi or pulkomandy review.
However, a couple comments:
1. don't you also need to address padding for this class?
2. the doxygen documentation looks incorrect; it has `BControl::SetIcon`
rather than `BBitmap::SetIcon`
--
Ticket URL: <https://dev.haiku-os.org/ticket/11394#comment:6>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] Re: [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc. - jessicah
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] Re: [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash
- » [haiku-bugs] Re: [Haiku] #11394: [PATCHes] BToolbar rework, standard icons, etc.- waddlesplash