[haiku-bugs] Re: [Haiku] #11726: Adding PORT to domain name causes WebPositive to do a Google search instead of load the web page
- From: "leavengood" <trac@xxxxxxxxxxxx>
- Date: Tue, 13 Jan 2015 19:03:20 -0000
#11726: Adding PORT to domain name causes WebPositive to do a Google search
instead
of load the web page
----------------------------------------+----------------------------
Reporter: codewrangler | Owner: pulkomandy
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications/WebPositive | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
----------------------------------------+----------------------------
Comment (by leavengood):
The code I originally wrote for this was very stupid, though it seems to
have been improved a lot in subsequent years:
http://cgit.haiku-
os.org/haiku/tree/src/apps/webpositive/BrowserWindow.cpp#n2465
We probably just need to create a new class to handle this and mimic
Chrome's logic:
https://code.google.com/p/chromium/codesearch#chromium/src/components/omnibox/autocomplete_input.cc&l=132
The above is pretty complicated (and maybe more complicated than we need),
but it is well commented.
Having some unit tests around it would be good probably.
This would be a great little piece of code for someone to contribute!
I would enjoy doing it but don't have the time.
--
Ticket URL: <https://dev.haiku-os.org/ticket/11726#comment:3>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
