[haiku-bugs] Re: [Haiku] #11922: [PATCHSET] Add missing part of BMediaRoster and other improvements in media_kit
- From: "korli" <trac@xxxxxxxxxxxx>
- Date: Fri, 27 Mar 2015 08:20:20 -0000
#11922: [PATCHSET] Add missing part of BMediaRoster and other improvements in
media_kit
------------------------------+----------------------------
Reporter: Barrett | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Kits/Media Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------+----------------------------
Comment (by korli):
About 0002:
* port < B_OK is usually used to check for an error on create_port() call.
* status and reply.status should be checked for B_OK equality.
* "else status = B_OK;" can then be left out.
* shouldn't BMediaNode::TimerExpired() do something with the parameters
notifyPoint and error?
* wait_port isn't a coding style valid c++ name. waitPort would be better.
--
Ticket URL: <https://dev.haiku-os.org/ticket/11922#comment:2>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
