#12319: Time/NTP sometimes crashes in gethostbyname()
----------------------------------+----------------------------
Reporter: ttcoder | Owner: nobody
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Network & Internet | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------+----------------------------
Comment (by axeld):
Thanks for your contribution! I haven't actually tested your code, but it
does look okay and functioning.
I have a few remarks, though:
* Please try to follow our [https://www.haiku-os.org/development/coding-
guidelines coding style] closely. A good start would be trying hard to not
make your changes stand out, but it would be even more appreciated to give
the guide itself a read :-)
* Please consider using the BNetworAddressResolver class, as in the
example from ttcoder 19 months ago. It has a much nicer API, and would
allow you to avoid those stringify macros completely. It's also much less
likely to leak any memory with it, although your patch seems to deal with
that appropriately.
--
Ticket URL: <https://dev.haiku-os.org/ticket/12319#comment:8>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
