[haiku-bugs] Re: [Haiku] #12578: Wrong colour for BSlider hash marks
- From: "looncraz" <trac@xxxxxxxxxxxx>
- Date: Fri, 15 Jan 2016 05:58:04 -0000
#12578: Wrong colour for BSlider hash marks
----------------------------------+----------------------------
Reporter: humdinger | Owner: axeld
Type: bug | Status: new
Priority: blocker | Milestone: R1/beta1
Component: Kits/Interface Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 12588
Has a Patch: 0 | Platform: All
----------------------------------+----------------------------
Comment (by looncraz):
Replying to [comment:11 jessicah]:
That's not what the B_CONTROL_MARK constant is used for. In pre-merge
ControlLook, it was pretty much the exclusive realm of checkboxes and
radio buttons, and should stay this way. The other solutions are just
hacks around what is genuinely a mistake when this behaviour was changed.
If we use R5.1/dan0 as a reference, the control highlight color should be
used for those purposes... but that's just because the mark color didn't
exist, IIRC... though dan0 didn't use the control highlight color for the
hashmarks, it used a very different way of drawing sliders (a really nice
way, IMHO:
http://files.looncraz.net/Dan0Slider.png ;).
In the end, the only "right" way is the way that is agreed upon. To me, a
control which has indicator marks... should probably use the control mark
color in some way :p. Granted, I think it would be best used on only the
selected mark... but the hashmarks don't always line up with the usable
values, so it'd have to be an overlay indicator.
I do like the thin marks, though.
Restoring the former behavior is a simple matter of using
B_PANEL_BACKGROUND_COLOR instead of B_CONTROL_MARK_COLOR, if everyone is
so resistant to changing the previous appearance (I can always work on my
own control look if I were adamant :p).
--
Ticket URL: <
https://dev.haiku-os.org/ticket/12578#comment:12>
Haiku <
https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
