[haiku-bugs] Re: [Haiku] #12982: Screen is shifted a few pixels down leaving unused black space on the top

  • From: "kallisti5" <trac@xxxxxxxxxxxx>
  • Date: Mon, 03 Oct 2016 14:58:49 -0000

#12982: Screen is shifted a few pixels down leaving unused black space on the 
top
----------------------------------------------+----------------------------
   Reporter:  FridayHaiku                     |      Owner:  pulkomandy
       Type:  bug                             |     Status:  assigned
   Priority:  normal                          |  Milestone:  Unscheduled
  Component:  Drivers/Graphics/intel_extreme  |    Version:  R1/Development
 Resolution:                                  |   Keywords:
 Blocked By:                                  |   Blocking:
Has a Patch:  0                               |   Platform:  All
----------------------------------------------+----------------------------

Comment (by kallisti5):

 Ok, he undid a lot of those horrible hacks in hrev50512.  Looking at the
 commits hrev50512 looks to contain the regression somewhere.

 Regression causes:

 **Strong Maybe**
 Things I don't agree with and need some additional research on their
 correctness. Intel docs say you *always* need to unlock the panel register
 on PCH or they won't change when modified.
 * LVDSPort init - No longer unlocking panel registers if PCH
 * enable_lvds_panel - No longer unlocking panel registers if PCH

 **Weak Maybe**
 I want to beleve there was some research to this change as it "feels" ok
 ```^_^```
 * ConfigureTimings - Checking for a transcoder before setting display
 timings


 I actually see the last change potentially causing the code to loop
 forever... if the panel registers aren't unlocked, you can't modify them
 to turn the panel on.  If you can't modify them, the panel will never turn
 on... thus the for loop runs forever.

--
Ticket URL: <https://dev.haiku-os.org/ticket/12982#comment:7>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: