[haiku-bugs] Re: [Haiku] #13401: Check some more values for ext2_super_block

  • From: "pulkomandy" <trac@xxxxxxxxxxxx>
  • Date: Fri, 31 Mar 2017 05:31:42 -0000

#13401: Check some more values for ext2_super_block
---------------------------------+----------------------------
   Reporter:  wangxindsb         |      Owner:  nobody
       Type:  enhancement        |     Status:  reopened
   Priority:  normal             |  Milestone:  R1
  Component:  File Systems/ext2  |    Version:  R1/Development
 Resolution:                     |   Keywords:  GSoC 2017
 Blocked By:                     |   Blocking:
Has a Patch:  1                  |   Platform:  All
---------------------------------+----------------------------

Comment (by pulkomandy):

 I already removed the Has64bitFeature() call in our master branch to fix
 the build, so you should work from the latest version.
 See http://cgit.haiku-
 os.org/haiku/commit/?id=6bbb8b3022eb6691784e14aee705bd3fb4118989 for my
 changes.

 Also check the coding style. The previous patch had problems (as reviewed
 on the commits mailing list: //www.freelists.org/post/haiku-commits
 /haiku-hrev51052-srcaddonskernelfile-systemsext2,1 ) and I think you still
 have a line that is above 80 columns.

--
Ticket URL: <https://dev.haiku-os.org/ticket/13401#comment:8>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: