[haiku-bugs] Re: [Haiku] #13496: The blue border for File Panel focus does not update correctly

  • From: "looncraz" <trac@xxxxxxxxxxxx>
  • Date: Sun, 14 May 2017 21:28:59 -0000

#13496: The blue border for File Panel focus does not update correctly
----------------------------------+---------------------------------
   Reporter:  owenca              |      Owner:  nobody
       Type:  bug                 |     Status:  new
   Priority:  high                |  Milestone:  R1/beta1
  Component:  Kits/libtracker.so  |    Version:  R1/Development
 Resolution:                      |   Keywords:  Tracker, BFilePanel
 Blocked By:                      |   Blocking:
Has a Patch:  1                   |   Platform:  All
----------------------------------+---------------------------------

Comment (by looncraz):

 Awesome!  I was just refreshing to the latest hrev and you have a patch :p

BContainerWindow* window = dynamic_cast<BContainerWindow*>(Window());

 If you're going to use dynamic_cast you should probably check for NULL. In
 this case, though, I'd think that static_cast would be more appropriate.

 Also, the "Save as now" seems to be missing the border entirely, which
 might just be the color choice (probably changing color_which base =
 B_DOCUMENT_BACKGROUND_COLOR to B_PANEL_BACKGROUND_COLOR on line 4418 of
 ContainerWindow.cpp will resolve that).

--
Ticket URL: <https://dev.haiku-os.org/ticket/13496#comment:8>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts:

  1. Home
  2. haiku-bugs
  3. Archive
  4. 05-2017