#13508: [Patch] Resolve Style Formatting Issue in
BTimeUnitFormat/BDurationFormat
-------------------------------+----------------------------
Reporter: akshay | Owner: pulkomandy
Type: bug | Status: new
Priority: normal | Milestone: Unscheduled
Component: Kits/Locale Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-------------------------------+----------------------------
Comment (by pulkomandy):
Commit message:
- Please break lines to a reasonable width (usually 80 columns)
TimeUnitFormat.h:
- Why the change in enum order?
DurationFormat.cpp
- Line 38: indentation problem? Should be indented just 1 tab (4 columns)
TimeUnitFormat.cpp
- If the style is invalid, fFormatter is never set. It should be set to
NULL.
- I think you do not need the "s" prefix in skStyleMap. kStyleMap should
be enough. Also it could have a more descritive name, kTimeUnitStyleToICU
maybe?
--
Ticket URL: <https://dev.haiku-os.org/ticket/13508#comment:2>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
