#13550: WebPositive history is not updated in certain cases
-------------------------------------+-------------------------------------
Reporter: accessays | Owner: pulkomandy
Type: bug | Status: new
Priority: normal | Milestone: Unscheduled
Component: | Version: R1/Development
Applications/WebPositive | Keywords: url, webpositive,
Resolution: | history, navigation
Blocked By: | Blocking:
Has a Patch: 1 | Platform: x86
-------------------------------------+-------------------------------------
Comment (by pulkomandy):
Ok, I took a closer look at the patch. I think it goes the wrong way about
this.
The idea is that WebKit should be handling all this stuff, and telling us
what to do: should the stop button be enabled? Is there a new entry in the
history, or is the load just a redirect of a previous request? etc.
The application should not get to handle the LOAD_DL_COMPLETED,
LOAD_COMMITTED, etc messages by itself (it can do so, but only to handle
other specific things - not the button states that are handled by WebKit).
Likewise, calling ResendNotifications directly is not the right thing to
do - this should be done on WebKit side.
The reason which makes this important is that WebPositive isn't the only
browser using the API. In fact, the WebKit test suite is run with a
smaller browser (called HaikuLauncher), and this should be kept behaving
the same as the real Web+. Otherwise, the testsuite is not very useful.
So, your changes may be correct, but they should be implemented on WebKit
side, at Source/WebKit/haiku/API/BrowserWindow.cpp . This way, everyone
using WebKit will get a working stop button, not just Web+.
With regard to the changes about the URL locking, they look good, and I
could apply just that part if it is split out of the patch file.
--
Ticket URL: <https://dev.haiku-os.org/ticket/13550#comment:6>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
