[haiku-bugs] Re: [Haiku] #15172: SMAP violation when attaching FTDI based serial device

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Tue, 23 Jul 2019 14:20:09 -0000

#15172: SMAP violation when attaching FTDI based serial device
---------------------------+----------------------------
   Reporter:  probono      |      Owner:  nobody
       Type:  bug          |     Status:  new
   Priority:  normal       |  Milestone:  Unscheduled
  Component:  Drivers/TTY  |    Version:  R1/Development
 Resolution:               |   Keywords:
 Blocked By:               |   Blocking:
Has a Patch:  0            |   Platform:  All
---------------------------+----------------------------
Changes (by waddlesplash):

 * owner:  waddlesplash => nobody
 * cc: PulkoMandy (added)
 * component:  Drivers/USB/XHCI => Drivers/TTY


Comment:

 Actually the real culprit seems to be this:
 https://github.com/haiku/haiku/blob/master/src/add-
 ons/kernel/drivers/ports/usb_serial/SerialDevice.cpp#L91

 Since this create_area is called in the kernel, it will be mapped into the
 kernel address space but with user-writeable permissions; thus
 IS_USER_ADDRESS will return false and the USB stack will not use the user
 functions to access it.

 AFAICT, it is not used outside this driver or passed to user-space, so the
 solution seems to be to simply change it to be mapped in the kernel only.
 PulkoMandy, can you confirm this is correct?

-- 
Ticket URL: <https://dev.haiku-os.org/ticket/15172#comment:13>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: