[haiku-bugs] Re: [Haiku] #15254: BWindow shouldn't dispatch messages on behalf of BView

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Sat, 17 Aug 2019 16:41:49 -0000

#15254: BWindow shouldn't dispatch messages on behalf of BView
----------------------------------+----------------------------
   Reporter:  simonsouth          |      Owner:  nobody
       Type:  bug                 |     Status:  new
   Priority:  normal              |  Milestone:  Unscheduled
  Component:  Kits/Interface Kit  |    Version:  R1/Development
 Resolution:                      |   Keywords:
 Blocked By:                      |   Blocking:
Has a Patch:  0                   |   Platform:  All
----------------------------------+----------------------------

Comment (by simonsouth):

So this potential change should not break this at all.

 Right, it doesn't; I've built a Haiku image with my changes applied
 (moving all the dispatch logic into BView::MessageReceived()) and it runs
 just fine without changes to the apps. (BView doesnt inherit from BLooper,
 so BView::CurrentMessage() doesn't exist.)

 Although I'm surprised BeOS works the way it does, applying this change
 would make Haiku consistent with Be's ''[https://www.haiku-os.org/legacy-
 
docs/bebook/TheKeyboard_JourneyOfAKeystroke.html#TheKeyboard_JourneyOfAKeystroke_Step3
 description]'' of how the system was meant to work:

     If it's not a key the BWindow class (or derived class) wants to
 intercept, DispatchMessage() passes the message along to the currently
 focused view's BView::MessageReceived() function.

-- 
Ticket URL: <https://dev.haiku-os.org/ticket/15254#comment:9>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: