[haiku-bugs] Re: [Haiku] #15751: Font fallback wrong for non-regular font variant (noto sans display)

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Sat, 29 Feb 2020 17:11:30 -0000

#15751: Font fallback wrong for non-regular font variant (noto sans display)
----------------------------------+----------------------------
   Reporter:  nephele             |      Owner:  axeld
       Type:  bug                 |     Status:  new
   Priority:  normal              |  Milestone:  Unscheduled
  Component:  Servers/app_server  |    Version:  R1/Development
 Resolution:                      |   Keywords:
 Blocked By:                      |   Blocking:
Has a Patch:  0                   |   Platform:  All
----------------------------------+----------------------------
Comment (by nephele):

 diff --git a/src/servers/app/font/GlyphLayoutEngine.h
 b/src/servers/app/font/GlyphLayoutEngine.h
 index 71d026cb3e..e488eb9604 100644
 --- a/src/servers/app/font/GlyphLayoutEngine.h
 +++ b/src/servers/app/font/GlyphLayoutEngine.h
 @@ -335,8 +335,9 @@ GlyphLayoutEngine::_WriteLockAndAcquireFallbackEntry(
         // Try to get the glyph from the fallback fonts
         while (fallbacks[i] != NULL) {
                 if (gFontManager->Lock()) {
 -                       FontStyle* fallbackStyle =
 gFontManager->GetStyleByIndex(
 -                               fallbacks[i], 0);
 +                       FontStyle* fallbackStyle = gFontManager->GetStyle(
 +                               fallbacks[i], font.Style());
 +
                         if (fallbackStyle != NULL) {
                                 ServerFont fallbackFont(*fallbackStyle,
 font.Size());
                                 gFontManager->Unlock();
-- 
Ticket URL: <https://dev.haiku-os.org/ticket/15751#comment:2>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: