[haiku-bugs] Re: [Haiku] #16354: Revert button needs to be clicked twice to activate after brightness was changed

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Fri, 03 Jul 2020 23:19:30 -0000

#16354: Revert button needs to be clicked twice to activate after brightness was
changed
---------------------------------+--------------------------------------
  Reporter:  accessays           |      Owner:  axeld
      Type:  bug                 |     Status:  new
  Priority:  low                 |  Milestone:  Unscheduled
 Component:  Preferences/Screen  |    Version:  R1/Development
Resolution:                      |   Keywords:  brightness,screen,revert
Blocked By:                      |   Blocking:
  Platform:  x86-64              |
---------------------------------+--------------------------------------
Comment (by accessays):

 Clicking Revert button ends up calling `_UpdateActiveMode` which calls
 `_UpdateControls` which calls `_CheckApplyEnabled`, which enables or
 disables the Revert button. In message handler (for BUTTON_REVERT_MSG)
 `_UpdateActiveMode` is called before brightness is reset, so Revert button
 stays enabled.

 Attached patch is one way to fix that, by simply calling
 `_UpdateActiveMode` ''after'' brightness has been reset.
-- 
Ticket URL: <https://dev.haiku-os.org/ticket/16354#comment:1>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: