#16922: MediaPlayer does not hold settings
---------------------------------------+-------------------------
Reporter: vidrep | Owner: stippi
Type: bug | Status: new
Priority: normal | Milestone: Unscheduled
Component: Applications/MediaPlayer | Version: R1/beta2
Resolution: | Keywords:
Blocked By: | Blocking:
Platform: All |
---------------------------------------+-------------------------
Comment (by modeenf):
But how can this commit brake that? it's the same code(more or less)
https://git.haiku-
os.org/haiku/commit/?id=6375ef053d7770a8af1389fda494fac25c131360
To make a converter we need to know what type it was before. But if we
don't do a converter we need to have this workaround in Known fixes in the
Release documentation for Beta3
The only thing I can think of can brake this are that now handle uint32
"correct".
Before
{{{
uint32
SettingsMessage::GetValue(const char* name, uint32 defaultValue) const
{
int32 value;
if (FindInt32(name, &value) != B_OK)
return defaultValue;
return (uint32)value;
}
}}}
now
{{{
uint32
SettingsMessage::GetValue(const char* name, uint32 defaultValue) const
{
uint32 value;
if (FindUInt32(name, &value) != B_OK)
return defaultValue;
return value;
}
}}}
--
Ticket URL: <https://dev.haiku-os.org/ticket/16922#comment:5>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
