#1876: Media preferences, clicking on some checkboxes switches back to first tab
-----------------------------------+----------------------------
Reporter: aldeck | Owner: leavengood
Type: bug | Status: assigned
Priority: normal | Milestone: R1
Component: Add-Ons/Media/Mixer | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
-----------------------------------+----------------------------
Comment (by leavengood):
Regarding Axel and Rene's comments in 7 and 8 above: I don't see how the
default media theme could know what it needs to change when parameters are
changed in this way. For example if the channel count changes and we need
more sliders, how is the media theme supposed to know that? The channel
count seems to be internal knowledge to the mixer.
But maybe the way the parameter web is built could be adjusted for this.
It is still true that the B_MEDIA_PARAMETER_CHANGED message sent from the
mixer side is not handled in the default media theme.
So maybe this could be fixed with a combination of adding support for
handling that message in the media theme, and adjusting aspects of how the
mixer handles settings so that the theme can know how many channels there
are for purposes of setting the channel count in the parameter.
I'll keep looking at it and do some testing to try to sort it out. Other
aspects of the mixer code are quite strange, like this if statement with
"&& 1" at the end, which is used in several places:
https://xref.plausible.coop/source/xref/haiku/src/add-ons/media/media-add-
ons/mixer/AudioMixer.cpp#1332
I can't really tell from the Git history who wrote that or why because
this code was imported this way from SVN and the commit message is just
"added balance control to output":
https://github.com/haiku/haiku/commit/5fa60b3b6490368a7ac762b1f34ca22327e0dd6c
#diff-68f185f9812b1dacc7cdd3fd8ffdd0fc
This is very old code, it may be worth doing a more thorough audit and
clean up because the mixer is pretty important for audio output...
--
Ticket URL: <https://dev.haiku-os.org/ticket/1876#comment:14>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
