[haiku-bugs] Re: [Haiku] #3385: Open Disks Icon with Single Window Navigation = no draggable folder icon in upper right
- From: "aldeck" <trac@xxxxxxxxxxxx>
- Date: Wed, 21 Jul 2010 11:35:26 -0000
#3385: Open Disks Icon with Single Window Navigation = no draggable folder icon
in
upper right
-----------------------------------+----------------------------------------
Reporter: mmadia | Owner: aldeck
Type: bug | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/Tracker | Version: R1/pre-alpha1
Resolution: | Keywords:
Blocked By: | Has a Patch: 0
Platform: All | Blocking:
-----------------------------------+----------------------------------------
Changes (by aldeck):
* owner: axeld => aldeck
* status: new => assigned
Comment:
Thanks! I'll have a look soon, though i'm about to commit big changes in
tracker in the comming days (regarding layout kit and containerwindow /
poseview ties).
Your patch will need to be "ported" to the future code, but in the mean
time, you will need to improve the patch anyway (see below).
I'd like you to explain more in detail the changes you did, i.e: why the
previous code was buggy and how you changed it.
If you'd like to leave commented out code (that's rarely needed) you
should explain clearly why in the code itself (or update an existing
comment to reflect a new reality).
Concerning style, a few blank lines were unnecessarily added/removed and
some spaces at line endings as well as bad spacing before brackets. You
create a local variable fMenuBar, names starting with "f" are reserved for
class member variables.
Best regards.
--
Ticket URL: <http://dev.haiku-os.org/ticket/3385#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
