[haiku-bugs] Re: [Haiku] #3637: [preferences/FileTypes] menuField text is clipped(easy)

  • From: "stippi" <trac@xxxxxxxxxxxx>
  • Date: Wed, 03 Mar 2010 08:03:39 -0000

#3637: [preferences/FileTypes] menuField text is clipped(easy)
-----------------------------------+----------------------------------------
 Reporter:  chico                  |       Owner:  axeld         
     Type:  bug                    |      Status:  new           
 Priority:  normal                 |   Milestone:  R1            
Component:  Preferences/FileTypes  |     Version:  R1/Development
 Keywords:                         |   Blockedby:                
 Platform:  All                    |    Blocking:                
-----------------------------------+----------------------------------------

Comment(by stippi):

 Thanks, this looks like the correct fix indeed. However, a few nitpicks on
 the patch :-) - don't put spaces after and before enclosing parenthesis,
 and I *think* the hardcoded -15 could be avoided by looking at the "item
 margins". In BMCPrivate.cpp, in _BMCMenuBar_::_Init(), you can see that it
 uses SetItemMargins() and indeed BMenuField has the popup indicator
 optional, so hardcoding this isn't so good. Hopefully you can get to the
 item margins in that BMenuItem method, but I think it should be the case.
 Thanks a lot for having looked into this!

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/3637#comment:17>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: