[haiku-bugs] Re: [Haiku] #4146: Magnify doesn't resize nicely

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Sat, 29 Oct 2011 16:38:33 -0000

#4146: Magnify doesn't resize nicely
------------------------------------+---------------------------
   Reporter:  atmartens             |      Owner:  axeld
       Type:  bug                   |     Status:  new
   Priority:  normal                |  Milestone:  R1
  Component:  Applications/Magnify  |    Version:  R1/pre-alpha1
 Resolution:                        |   Keywords:
 Blocked By:                        |   Blocking:
Has a Patch:  1                     |   Platform:  All
------------------------------------+---------------------------

Comment (by axeld):

 Sorry for the very late reply; your patch has two issues that would need
 to be solved (I even tried, but the Magnify code is quite scary):
 * When closing the window while the info is not visible due to the size,
 it will lose the setting.
 * You make members public to get the preferred size of the widget. While
 that kind of fits to the coding style within Magnify, it would be much
 better to actually implement GetPreferredSize() for the info view instead,
 and use that (including the height of the window) to judge whether or not
 the info view should be visible.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/4146#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: