[haiku-bugs] Re: [Haiku] #4689: Add shortcuts to StyledEdit

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Mon, 29 Nov 2010 21:56:58 -0000

#4689: Add shortcuts to StyledEdit
--------------------------------------+-------------------------
  Reporter:  ilembitov                |        Owner:  korli
      Type:  enhancement              |       Status:  closed
  Priority:  normal                   |    Milestone:  R1
 Component:  Applications/StyledEdit  |      Version:  R1/alpha1
Resolution:  fixed                    |     Keywords:
Blocked By:                           |  Has a Patch:  1
  Platform:  All                      |     Blocking:
--------------------------------------+-------------------------
Changes (by axeld):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Applied in r39680, thanks a lot! I've made the following changes:
 * Renamed SET_BOLD|ITALIC to kMsgSetBold|Italic - while you just copied
 what was there (which is usually the safe thing to do), our coding style
 demands to name constants this way :-)
 * SetMarked() expects a boolean value - and our coding style requires to
 use {{{!= 0}}} in this case.
 * You missed a space after the {{{if}}} in the message handling code.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/4689#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: