[haiku-bugs] Re: [Haiku] #4930: Keyboard navigating context menu
- From: "Ziusudra" <trac@xxxxxxxxxxxx>
- Date: Sun, 23 May 2010 08:40:53 -0000
#4930: Keyboard navigating context menu
--------------------------------+-------------------------------------------
Reporter: humdinger | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Kits/Interface Kit | Version: R1/alpha2
Keywords: | Platform: All
Blockedby: | Patch: 1
Blocking: |
--------------------------------+-------------------------------------------
Comment(by Ziusudra):
OK, hows this one look.
After verifying that _Show() was always called for menus, as it should be,
I moved the AddDynamicItem() loop into _Show() before it calls
BMenuWindow->AttachMenu(). This allows for passing the bool keyDown (which
defaults to false if not passed) from KeyDown() through the chain into
_OkToProceed().
This has the benefit that if user actions abort the submenu it never gets
attached rather than attaching and detaching.
I tested everything I could think of involving mouse and keyboard
navigation; all Tracker, Deskbar and application menus function as
desired. All dynamic filesystem menus open with both keyboard and mouse.
And again, while testing I didn't get any lockups I would normally have
gotten while using the keyboard, so that has at least been greatly
reduced.
--
Ticket URL: <http://dev.haiku-os.org/ticket/4930#comment:12>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
