[haiku-bugs] Re: [Haiku] #5110: [patch] Configure option to install OptionalPackage's sources

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Mon, 21 Dec 2009 17:13:59 -0000

#5110: [patch] Configure option to install OptionalPackage's sources
--------------------------+-------------------------------------------------
 Reporter:  mmadia        |       Owner:  bonefish 
     Type:  enhancement   |      Status:  new      
 Priority:  normal        |   Milestone:  R1/alpha2
Component:  Build System  |     Version:  R1/alpha1
 Keywords:                |   Blockedby:           
 Platform:  All           |    Blocking:           
--------------------------+-------------------------------------------------

Comment(by bonefish):

 More like (untested):
 {{{
 rule DownloadFile file : url
 {
         file = $(file:G=download) ;

         # Request the download only once.
         if [ on $(file) return $(HAIKU_FILE_DOWNLOAD) ] {
                 return $(file) ;
         }

         HAIKU_FILE_DOWNLOAD on $(file) = 1 ;

         MakeLocate $(file) : $(HAIKU_DOWNLOAD_DIR) ;
         DownloadLocatedFile $(file) : $(url) ;

         return $(file) ;
 }

 rule DownloadOptionalPackage package : url
 {
         return [ DownloadFile $(package).zip : $(url) ] ;
 }
 }}}

 DownloadSourceArchive becomes superfluous, as it is equivalent to
 DownloadFile. I would even consider getting rid of DownloadOptionalPackage
 and use DownloadFile instead.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5110#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: