[haiku-bugs] Re: [Haiku] #5149: [Patch] Applying BGridLayout to Terminal preference

  • From: "stippi" <trac@xxxxxxxxxxxx>
  • Date: Sat, 19 Dec 2009 08:08:57 -0000

#5149: [Patch] Applying BGridLayout to Terminal preference
-----------------------------------+----------------------------------------
 Reporter:  mt                     |       Owner:  jackburton    
     Type:  enhancement            |      Status:  new           
 Priority:  normal                 |   Milestone:  R1            
Component:  Applications/Terminal  |     Version:  R1/Development
 Keywords:                         |   Blockedby:                
 Platform:  All                    |    Blocking:                
-----------------------------------+----------------------------------------

Comment(by stippi):

 BTW, I know the code was like that before and you just cleaned it up, but
 the defensive programmers version would be more like this:

 {{{
     BMenuItem* item = fFont->Menu()->FindItem(
         PrefHandler::Default()->getString(PREF_HALF_FONT_FAMILY));
     if (item != NULL)
         item->SetMarked(true);
 }}}

 On the other hand, that would probably just hide an error elsewhere
 (mismatch of strings)... ;-)

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5149#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: