[haiku-bugs] Re: [Haiku] #5524: Make layout API public
- From: "yourpalal" <trac@xxxxxxxxxxxx>
- Date: Wed, 16 Nov 2011 02:03:19 -0000
#5524: Make layout API public
-------------------------------------------------+-------------------------
Reporter: mmadia | Owner: yourpalal
Type: enhancement | Status: in-progress
Priority: blocker | Milestone: R1/beta1
Component: Kits/Interface Kit | Version:
Resolution: | R1/Development
Blocked By: 5525, 5526, 5614, 6403, 6407, | Keywords:
6543, 6979, 7683 | Blocking:
Has a Patch: 0 | Platform: All
-------------------------------------------------+-------------------------
Comment (by yourpalal):
Replying to [comment:15 bonefish]:
> Not sure, if that was the issue I forgot in #5526 (it isn't FBC related,
though), but before making the layout API, I think the non-templatized
layout builders should be phased out. Either by removing them completely
and adjusting all code that uses them. Or (the lazy way) by moving them to
headers/private for the time being. Or (the very lazy way) the headers
should clearly be marked obsolete.
Yes, absolutely. I was thinking to add some compiler errors/warnings so
that third party apps can still build for a little while, but on further
reflection, if these are going to disappear from libbe, it is probably
worth it to do something a little stronger, since there will be runtime
errors down the line. Better to hurt the devs using unfinished API's than
the users ;) Maybe we can leverage GCI to get all the Haiku code using the
old builders converted.
> Moreover, it seems BSplitView could use some love. I assigned #7902 to
you. Also the method naming should be rechecked. E.g. we have
`Set*Item*Weight()`, but `SetCollapsible()` (the item/items version, I
mean). Also `Is[Item]Collapsible()` would be nice to have, as well as
`Set[Item]Collapsed()` and `Is[Item]Collapsed()`.
Yes, naming is another thing I want to go over, making sure everything is
consistent and easy to understand. Another example is the BAbstract*
classes have hook methods name Base*(), but I wonder if they should be
renamed to something like Derived*(), which is more correct, I think, and
is also used elsewhere (IIRC).
--
Ticket URL: <http://dev.haiku-os.org/ticket/5524#comment:16>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
