[haiku-bugs] Re: [Haiku] #5525: Implement archiving in layouting classes
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Sat, 17 Jul 2010 01:06:19 -0000
#5525: Implement archiving in layouting classes
-------------------------------------+--------------------------------------
Reporter: mmadia | Owner: bonefish
Type: enhancement | Status: in-progress
Priority: normal | Milestone:
Component: Kits/Interface Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: 6256, 6257, 6302, 6314 | Has a Patch: 1
Platform: All | Blocking: 5524
-------------------------------------+--------------------------------------
Comment (by bonefish):
Applied the BSpaceLayoutItem patch in r37547 with some style corrections,
most notably:
{{{
Index: src/kits/interface/SpaceLayoutItem.cpp
===================================================================
--- src/kits/interface/SpaceLayoutItem.cpp (revision 37523)
+++ src/kits/interface/SpaceLayoutItem.cpp (working copy)
@@ -1,29 +1,58 @@
/*
+ * Copyright 2010, Haiku, Inc.
* Copyright 2006, Ingo Weinhold <bonefish@xxxxxxxxxxxxxxx>.
* All rights reserved. Distributed under the terms of the MIT License.
*/
+#include <new>
+
+#include <Message.h>
#include <SpaceLayoutItem.h>
}}}
The header corresponding to the source file should be the first one (and
separated). This makes sure the header is self-contained.
{{{
void
-BSpaceLayoutItem::SetFrame(BRect frame)
-{
+BSpaceLayoutItem::SetFrame(BRect frame) {
}}}
Beep. In case you wonder why some methods used this incorrect style, those
were probably left-overs. I originally prototyped the layout functionality
in Java and just transcribed most of it to C++ afterwards. That's also the
reason for `BLayout::Item{Added,Removed}` not having gotten a return type,
since memory allocation issues are reported via exception in Java.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5525#comment:18>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
