[haiku-bugs] Re: [Haiku] #5563: [Patch] ShowImage app localization
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Sun, 14 Mar 2010 21:29:15 -0000
#5563: [Patch] ShowImage app localization
-----------------------------+----------------------------------------------
Reporter: mt | Owner: stippi
Type: enhancement | Status: in-progress
Priority: normal | Milestone: R1
Component: Kits/Locale Kit | Version: R1/Development
Keywords: ShowImage | Blockedby:
Platform: All | Blocking:
-----------------------------+----------------------------------------------
Changes (by stippi):
* owner: pulkomandy => stippi
* status: new => in-progress
Comment:
The patch looks pretty good, thanks a lot!
Just some possible improvements for future patches:
* You could include ControlLook.h and use
be_control_look->DefaultItemSpacing() instead of hardcoding 5 or so for
layout item spacing. I.e. "float spacing =
be_control_look->DefaultItemSpacing();" once and then using "spacing"
everywhere.
* The bs_printf() function has some tabs or weird spacing between type
and variable names.
* The coding cleanups are greatly appreciated. In some places you could
also improve variable names to be slightly more descriptive, but it would
certainly not prevent me from applying this patch.
Thanks for the good work you are doing, mt. IMHO you should be proposed
for commit access soon. :-)
--
Ticket URL: <http://dev.haiku-os.org/ticket/5563#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
