[haiku-bugs] Re: [Haiku] #5619: [PATCH] Add support for setting local domain to network prefs + dhcp client
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Tue, 23 Mar 2010 20:10:27 -0000
#5619: [PATCH] Add support for setting local domain to network prefs + dhcp
client
---------------------------------+------------------------------------------
Reporter: vegardw | Owner: stippi
Type: enhancement | Status: in-progress
Priority: normal | Milestone: R1
Component: Preferences/Network | Version: R1/Development
Keywords: dns dhcp | Blockedby:
Platform: All | Blocking:
---------------------------------+------------------------------------------
Changes (by stippi):
* owner: axeld => stippi
* status: new => in-progress
Comment:
Thanks! Functionally, the patch looks fine. I am just uncertain with
regards to overwriting resolv.conf, but that's just the same as the rest
of the preflet. Before I can apply your patch, you need to fix some style
issues. Mostly it seems your editor has the wrong tab settings. Just look
at the patch here in Trac, and you can easily spot the wrong indentation.
We use four spaces indentation per tab, and use tabs exclusively, no
spaces. The other problem is with regards to parenthesis. We use this
style:
{{{
if (condition) {
}
}}}
I.e. space between if and ( and parenthesis on the same line. If you could
fix those, I'll be happy to apply your work! Thanks again!
--
Ticket URL: <http://dev.haiku-os.org/ticket/5619#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
