[haiku-bugs] Re: [Haiku] #5912: Devices localization patch
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Sat, 17 Jul 2010 12:49:29 -0000
#5912: Devices localization patch
-----------------------------------+----------------------------------------
Reporter: Karvjorm | Owner: pulkomandy
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/Devices | Version: R1/alpha1
Resolution: | Keywords: Devices localization patch
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-----------------------------------+----------------------------------------
Comment (by pulkomandy):
There are still problems with the blank lines between blocks.
You have to skip two lines between the last #include statement and the
#undef TR_CONTEXT, and two lines again after the #define TR_CONTEXT and
before the start of the code. It should look like this :
{{{
...
#include <something.h>
#undef TR_CONTEXT
#define TR_CONTEXT my_app
class SomeThing {
...
}}}
I see you also added some logic in device.cpp to handle the "unknown"
case. I think it is simpler to localize the string directly in Devices.h,
so that you don't have to mess with it afterwards. Or does that create
other problems ?
Also, the way you added HAIKU_LOCALE_LIBS in the jamfile goes over the
80-column limit.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5912#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
