[haiku-bugs] Re: [Haiku] #6118: [Patch] WebPositive Fallback fonts enhancement

  • From: "stippi" <trac@xxxxxxxxxxxx>
  • Date: Mon, 14 Jun 2010 13:36:51 -0000

#6118: [Patch] WebPositive Fallback fonts enhancement
--------------------------------------+-------------------------------------
 Reporter:  mt                        |       Owner:  stippi   
     Type:  enhancement               |      Status:  new      
 Priority:  normal                    |   Milestone:  R1       
Component:  Applications/WebPositive  |     Version:  R1/alpha2
 Keywords:                            |   Blockedby:           
    Patch:  1                         |    Platform:  All      
 Blocking:                            |  
--------------------------------------+-------------------------------------

Comment(by stippi):

 Thanks for the patch, it looks almost good: The WebCore layer changes are
 fine, but using them in the SettingsWindow class is a total layering
 violation. Everything must go through the WebKit API layer, no direct use
 of WebCore stuff in application code. It also means it happens in the
 wrong thread as a side effect. But if you move this code into the
 BWebSettings class, then it will be just fine.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6118#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: