[haiku-bugs] Re: [Haiku] #6271: support for images with a single rwx PT_LOAD program header
- From: "lucian" <trac@xxxxxxxxxxxx>
- Date: Tue, 06 Jul 2010 20:35:13 -0000
#6271: support for images with a single rwx PT_LOAD program header
----------------------------+-----------------------------------------------
Reporter: lucian | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: System/Kernel | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
----------------------------+-----------------------------------------------
Comment (by lucian):
Replying to [comment:9 bonefish]:
> Haven't tried to investigate what the issue is.
No need. I sent the wrong patch.
> {{{
> +
> + // Some add-ons may have .text and .data concatenated in a
single
> + // PT_LOAD RWE header and we must map that to .text.
> + if (programHeaders[i].IsReadWrite() &&
(countExecutableHeaders > 1)) {
> }}}
> Superfluous parenthesis.
It wasn't meant to be superfluous. I had another check here but forgot to
write it the first time, then fixed it, but sent the first patch :( Sorry
for wasting your time.
> Please use `(p_flags & PF_EXECUTE) != 0` respective `... == 0` to test
bits. Older Haiku code omits the `!= 0` respectively uses the `!`
operator, but new/touched code shouldn't.
>
I got inspired by the code above this one.
Remark duly noted.
--
Ticket URL: <http://dev.haiku-os.org/ticket/6271#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
