[haiku-bugs] Re: [Haiku] #6287: partition-type inconsistency
- From: "bebop" <trac@xxxxxxxxxxxx>
- Date: Mon, 22 Dec 2014 18:28:46 -0000
#6287: partition-type inconsistency
-------------------------------------+-------------------------------------
Reporter: starsseed | Owner: stippi
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: | Version: R1/alpha2
Applications/DriveSetup | Keywords: MBR file-system
Resolution: | partition-type
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
-------------------------------------+-------------------------------------
Comment (by bebop):
Obviously I have not worked on this code for a while, so take my comments
with a grain of salt. Adding a warning to the file system creation would
require that every file system add a check on creation. This seems like
extra work for the file system that does not really belong there. The file
system should not really know much about what partition it resides on, and
adding that check has the potential to expose a lot of detail about the
underlying disk systems and partition, all of which are supposed to be
abstracted at that level. As I stated in the first comment, it does not
really matter what partition type you create a file system on.
I do agree though that we should be able to edit the partition type post
facto. There is iirc a ParametersEditor class that you can write a BView
to be called from the API that would allow editing that sort of
information. I am not sure what shape that code is in though, so doing
some plumbing before getting to that point might be required.
So I guess I am a -1 on adding a message unless we can find a way to do it
that does not make the file system creation overly complicated. I am a +1
on having a decent ParametersEditor system and adding functionality to the
partition to allow it to be changed after it is created.
It is possible I will have some time over the holidays to take a look at
this. Any input is appreciated.
--
Ticket URL: <https://dev.haiku-os.org/ticket/6287#comment:3>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
