[haiku-bugs] Re: [Haiku] #6497: MediaConverter does not handle errors gracefully when sniffing files (easy)
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Mon, 25 Oct 2010 08:20:31 -0000
#6497: MediaConverter does not handle errors gracefully when sniffing files
(easy)
------------------------------------------+------------------------------
Reporter: yourpalal | Owner: yourpalal
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications/MediaConverter | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
------------------------------------------+------------------------------
Comment (by stippi):
Patch looks good, thanks. Some suggestions:
* When the passed file is NULL, return B_BAD_VALUE instead of B_ERROR.
* Initialize ret with B_OK instead of 0.
* Check for != B_OK instead of < B_OK. Technically the error codes are
negative, but we have switched to prefer the direct check for B_OK in new
code. (And old code where we come across it.)
Thanks a lot for your work! Coding style is fine, too.
--
Ticket URL: <http://dev.haiku-os.org/ticket/6497#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
