[haiku-bugs] Re: [Haiku] #6750: chmod is broken for non-superuser
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Wed, 03 Nov 2010 20:34:04 -0000
#6750: chmod is broken for non-superuser
-------------------------------+---------------------------------
Reporter: grahamh | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: File Systems/BFS | Version: R1/Development
Resolution: | Keywords: chmod, write_stat
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-------------------------------+---------------------------------
Comment (by axeld):
Replying to [comment:6 rohityadav]:
> Hi, patches attached for fixing the issue in BFS and ext2 file systems.
> Tested and works for me.
Thanks for the patches! However, you just moved grahamh's change into
CheckPermissions() - this does still have the same issues of not allowing
certain actions to happen at a time. What I suggested instead was pretty
much how Ingo solved it in his corruptionfs.
Besides that, there are indeed a few coding style problems:
* no superfluous parenthesis (ie. around (user == (uid_t)node.UserID())).
* use (a & b) != 0 instead of just (a & b).
* operators always go to the next line (the &&).
Would be great if you could update your patch!
--
Ticket URL: <http://dev.haiku-os.org/ticket/6750#comment:8>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
