[haiku-bugs] Re: [Haiku] #6847: Hard disks not shuting down cleanly (does not park heads)

  • From: "philcostin" <trac@xxxxxxxxxxxx>
  • Date: Sat, 13 Jun 2015 19:30:48 -0000

#6847: Hard disks not shuting down cleanly (does not park heads)
-------------------------+-------------------------------------------------
Reporter: aldeck | Owner: marcusoverhagen
Type: bug | Status: new
Priority: critical | Milestone: R1
Component: | Version: R1/alpha2
Drivers/Disk | Keywords: hard disk drive park heads shutdown
Resolution: | Blocking: 8657
Blocked By: 8112 | Platform: All
Has a Patch: 0 |
-------------------------+-------------------------------------------------

Comment (by philcostin):

CppCheck reveals "Shifting by a negative value is undefined behaviour" in
src/add-ons/kernel/busses/ata/ide_isa/ide_isa.c (line 123)

In write_command_block_regs

for (i=0; i<7; i++)
if (((1 << (i-7)) & mask != 0) <----


This means that it is undefined as to when the following call to
channel->isa->write_io_8() occurs.

--
Ticket URL: <https://dev.haiku-os.org/ticket/6847#comment:13>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: