[haiku-bugs] Re: [Haiku] #7002: Context menu for TextInput
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Mon, 20 Dec 2010 22:25:40 -0000
#7002: Context menu for TextInput
--------------------------+------------------------------------------------
Reporter: dancxjo | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: | Version: R1/Development
Kits/Interface Kit | Keywords: context menu text edit textinput
Resolution: | Has a Patch: 1
Blocked By: | Blocking:
Platform: All |
--------------------------+------------------------------------------------
Comment (by bonefish):
BTW, I can wholeheartedly recommend the `Menu` layout builder from
`<LayoutBuilders.h>` (e.g. cf. [http://dev.haiku-
os.org/browser/haiku/trunk/src/apps/terminal/TermWindow.cpp?rev=39690#L427
the Terminal menu code]). This should make things more compact and
pleasant to read, and if you determine first which items need to be
enabled/disabled, it should even be possible to get rid of all the
`BMenuItem*` variables.
The style violations I spotted at a quick glance:
- `is_redo` -> `isRedo`
- The `else` block has two lines and should therefore be enclosed in
braces.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7002#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
