[haiku-bugs] Re: [Haiku] #7052: Deskbar Style Changes and Refactoring
- From: "tqh" <trac@xxxxxxxxxxxx>
- Date: Mon, 31 Jan 2011 17:43:05 -0000
#7052: Deskbar Style Changes and Refactoring
-----------------------------------+---------------------------------
Reporter: jscipione | Owner: tqh
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/Deskbar | Version: R1/Development
Resolution: | Keywords: style refactoring
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-----------------------------------+---------------------------------
Comment (by tqh):
While I think your changes looks ok from a quick view, I find there is no
need for the silliness done in TBarApp using be_app to call BarView(). I
can't really see why TBarApp can't call BarView() directly. If I'm not
mistaken I think that call would be better than introducing a member for
fBarView.
Why use this source:haiku/trunk/src/apps/deskbar/BarApp.cpp#L426 when this
source:haiku/trunk/src/apps/deskbar/BarApp.h#L135 can be called directly?
--
Ticket URL: <http://dev.haiku-os.org/ticket/7052#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
