[haiku-bugs] Re: [Haiku] #7091: Bluetooth UI layer refactoring and improvement
- From: "yourpalal" <trac@xxxxxxxxxxxx>
- Date: Tue, 11 Jan 2011 21:20:04 -0000
#7091: Bluetooth UI layer refactoring and improvement
-------------------------------------------+------------------------------
Reporter: hamish | Owner: yourpalal
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Network & Internet/Bluetooth | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-------------------------------------------+------------------------------
Comment (by yourpalal):
Hi hamish, this patch looks good, but there are a 2 things I would change:
* Add a private OutputView* Output::_OutputViewAt(int32 index) method,
which gets the view from the tab at that index, then casts and returns it.
This will make things a little prettier too.
* I don't see the need for fOutputViewsList either, it's now only used in
one place, and you can use the above method to replace it.
Good catch on the 80-column limit as well. Thanks!
-Alex
--
Ticket URL: <http://dev.haiku-os.org/ticket/7091#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
