[haiku-bugs] Re: [Haiku] #7182: Fixing Menu keyboard navigation
- From: "jackburton" <trac@xxxxxxxxxxxx>
- Date: Tue, 01 Sep 2015 12:24:55 -0000
#7182: Fixing Menu keyboard navigation
----------------------------------+----------------------------
Reporter: Pete | Owner: stippi
Type: bug | Status: assigned
Priority: normal | Milestone: R1
Component: Kits/Interface Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------+----------------------------
Comment (by jackburton):
Replying to [comment:17 stippi]:
I've looked at the patch, but I am not familiar with the code enough to
have an opinion on your changes. You've removed some functionality and the
related comment "Seems not needed and to work better without!" does not
make me feel confident you really understood the purpose of the disabled
code. Doing changes in this code without fully understanding it tends to
produce unintended side effects. For example, at least in the Mouse
preflet, no BMenuField works anymore by clicking once to open and clicking
again to pick a menu item. So I don't feel confident in applying your
newest patch while I don't understand this code fully myself and your
comments don't suggest you fully understand this either. My solution to
the problem would be to rewrite this whole thing properly, in an object
oriented way, but I have no time. If you want to provide a patch for the
one item menu problem specifically, that would be fine.
#1621 has an old patch of mine which reimplements BMenu tracking using the
BView hooks. Could be adapted to work with current code. The only thing I
couldn't manage to work correctly was BMenuFields, but since they aren't
working correctly now, either, I would just go on with that route.
--
Ticket URL: <
https://dev.haiku-os.org/ticket/7182#comment:19>
Haiku <
https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
