[haiku-bugs] Re: [Haiku] #7394: Display zoom factor
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Mon, 02 Mar 2015 11:35:51 -0000
#7394: Display zoom factor
--------------------------------------+----------------------------
Reporter: humdinger | Owner: waddlesplash
Type: enhancement | Status: assigned
Priority: normal | Milestone: Unscheduled
Component: Applications/ShowImage | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------------+----------------------------
Comment (by axeld):
Hey Janus, I think your patch looks good. I have just two suggestions:
1. Instead of the relatively strange way to set the zoom text, why not use
BString::SetToFormat()?
1. Also, instead of duplicating the code to do so, please use a private
method that updates it instead.
Also, I spotted a minor style violation in that line: there is no space
after the cast.
It would be nice if you could give me a short notice if you are willing to
do these changes, otherwise I would apply your patch as is, and do them
myself.
--
Ticket URL: <https://dev.haiku-os.org/ticket/7394#comment:20>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
