[haiku-bugs] Re: [Haiku] #7449: Check for invalid Frame List Sizes and enable Asynchronous Park Capability [gsoc2011]

  • From: "mmlr" <trac@xxxxxxxxxxxx>
  • Date: Mon, 18 Apr 2011 08:06:53 -0000

#7449: Check for invalid Frame List Sizes and enable Asynchronous Park 
Capability
[gsoc2011]
--------------------------------+----------------------------
   Reporter:  gabriel.hartmann  |      Owner:  mmlr
       Type:  bug               |     Status:  new
   Priority:  normal            |  Milestone:  R1
  Component:  Drivers/USB       |    Version:  R1/Development
 Resolution:                    |   Keywords:  EHCI gsoc2011
 Blocked By:                    |   Blocking:
Has a Patch:  1                 |   Platform:  All
--------------------------------+----------------------------

Comment (by mmlr):

 Instead of putting everything in an additional if branch, please always
 try to return early. It makes the code easier to understand and in this
 case also avoids (ab-)using the "running" variable that is intended for
 the more narrow scope of the actual "running" check (hence the name).

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/7449#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: