[haiku-bugs] Re: [Haiku] #7951: [LaunchBox] add Open containing folder option (easy)
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Sun, 25 Mar 2012 10:53:26 -0000
#7951: [LaunchBox] add Open containing folder option (easy)
--------------------------------------+----------------------------
Reporter: diver | Owner: stippi
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/LaunchBox | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------------+----------------------------
Comment (by axeld):
Replying to [comment:7 abhiin1947]:
> 1. There are a lot of cases where the if conditions don't have an
RHS..is this a part of the guideline?
RHS = right hand side? The condition should always be a boolean condition
- if it already is, there is no need for a `== true`, for example.
Also, our coding style is evolving over time, too, and not everyone is
always writing perfect code, anyway. We just try hard to follow it as much
as possible, and try to only accept new code which follows it.
> 2. I have used the button as a reference because I thought it might help
while creating the add-on menu
What add-on menu do you mean?
Anyway, thanks for the update! Your patch looks very good now, and I would
apply it as soon as possible; while I don't have much time right now,
it'll happen next weekend at the latest.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7951#comment:8>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
