[haiku-bugs] Re: [Haiku] #8001: Regression: intel_extreme mode setting

  • From: "czeidler" <trac@xxxxxxxxxxxx>
  • Date: Wed, 01 Feb 2012 05:57:30 -0000

#8001: Regression: intel_extreme mode setting
-------------------------------------+-------------------------------------
   Reporter:  jprostko               |      Owner:  mmlr
       Type:  bug                    |     Status:  in-progress
   Priority:  high                   |  Milestone:  R1
  Component:                         |    Version:  R1/Development
  Drivers/Graphics/intel_extreme     |   Keywords:  intel_extreme,
 Resolution:                         |  1400x1050, mode
 Blocked By:                         |   Blocking:  8229
Has a Patch:  0                      |   Platform:  All
-------------------------------------+-------------------------------------

Comment (by czeidler):

 Whats about to first check for the modes in the mode list, like has been
 done before r42742 and if this does not work use a more general approach?
 This should at least make the driver usable again for many people.

 {{{

 --- a/src/add-ons/accelerants/intel_extreme/mode.cpp
 +++ b/src/add-ons/accelerants/intel_extreme/mode.cpp
 @@ -645,6 +645,22 @@ intel_propose_display_mode(display_mode* target,
 const display_mode* low,
  {
         TRACE(("intel_propose_display_mode()\n"));

 +       // just search for the specified mode in the list
 +
 +       for (uint32 i = 0; i < gInfo->shared_info->mode_count; i++) {
 +               display_mode *mode = &gInfo->mode_list[i];
 +
 +               // TODO: improve this, ie. adapt pixel clock to allowed
 values!!!
 +
 +               if (target->virtual_width != mode->virtual_width
 +                       || target->virtual_height != mode->virtual_height
 +                       || target->space != mode->space)
 +                       continue;
 +
 +               *target = *mode;
 +               return B_OK;
 +       }
 +
         sanitize_display_mode(*target);

         return is_display_mode_within_bounds(*target, *low, *high)

 }}}

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/8001#comment:38>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: