[haiku-bugs] Re: [Haiku] #812: Port PPP to the new stack
- From: "pdziepak" <trac@xxxxxxxxxxxx>
- Date: Sun, 06 Apr 2014 00:05:11 -0000
#812: Port PPP to the new stack
--------------------------------------+-----------------
Reporter: axeld | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Network & Internet/PPP | Version:
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------------+-----------------
Comment (by pdziepak):
Volatile integers are not needed here. Unfortunately, this patch series in
current form is very difficult to review as the majority of the patches
are fixes to the previous ones and definitely should not be merged.
However, I have noticed that `IPCP::fID` is accessed both using normal and
atomic operations and that doesn't look good. Actually, I am not even sure
that increment of `fID` really needs to be atomic (but I may be wrong).
--
Ticket URL: <https://dev.haiku-os.org/ticket/812#comment:17>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
