[haiku-bugs] Re: [Haiku] #8233: Patch for pthread_attr_getguardsize
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Wed, 04 Apr 2012 19:05:20 -0000
#8233: Patch for pthread_attr_getguardsize
--------------------------+------------------------------------------------
Reporter: unitedroad | Owner: bonefish
Type: | Status: assigned
enhancement | Milestone: R1
Priority: normal | Version: R1/Development
Component: | Keywords: pthread, pthread_attr_getguardsize
System/POSIX | Blocking:
Resolution: | Platform: All
Blocked By: |
Has a Patch: 1 |
--------------------------+------------------------------------------------
Comment (by bonefish):
I finally got around to review the patch:
- You didn't rebase after hrev43737, so the patch doesn't apply cleanly.
- I'm not really fond of `create_area_etc()` and
`vm_create_anonymous_area()` taking the number of guard pages instead of
the guard size. None of the other parameters is/contains a page count,
only sizes and addresses. (I guess it doesn't make much sense in the first
place that the macros for the default guard sizes
(`USER/KERNEL_STACK_GUARD_PAGES`) are page counts.)
- Mostly for sake of completeness: The `ThreadCreationAttributes`
constructor should init the newly introduced `guard_size` attribute.
- Wrappers for `pthread_attr_getguardsize()` and
`pthread_attr_setguardsize()` need to be added in
`src/libs/posix_error_mapper/`.
--
Ticket URL: <http://dev.haiku-os.org/ticket/8233#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
