[haiku-bugs] Re: [Haiku] #8902: Crash upon closing, after rapidly scrolling through many large photos

From: "Janus" <trac@xxxxxxxxxxxx>
Date: Tue, 03 Mar 2015 15:06:40 -0000

#8902: Crash upon closing, after rapidly scrolling through many large photos
--------------------------------------+----------------------------
   Reporter:  mmadia                  |      Owner:  axeld
       Type:  bug                     |     Status:  assigned
   Priority:  normal                  |  Milestone:  R1
  Component:  Applications/ShowImage  |    Version:  R1/Development
 Resolution:                          |   Keywords:
 Blocked By:                          |   Blocking:  7095
Has a Patch:  1                       |   Platform:  All
--------------------------------------+----------------------------

Comment (by Janus):

 Replying to [comment:4 axeld]:
 > Thanks for your contribution! The patch looks good, and seems to hit the
 problem on the nail.
 > I have some minor complaints, however:
 > - Why not use fQueue.front() instead of *begin()?

 I copied the code already present in the _QueueWorkerThread :-)

 > - I would never ask for a specific error code when trying to bail out of
 an otherwise endless loop. Just imagine you don't have the privileges to
 use find_thread() in a future Haiku, and get \ `B_PERMISSION_DENIED` back?

 B_NAME_NOT_FOUND is the only value returned in the bebook

 > - Is there maybe another way than to identify the threads by name?

 I use this method because is very simple. I can't think anything without
 saving the threadId. Do you have any suggestion?

 > - Is the window already closed at that time? Otherwise it might not be a
 nice user experience.

 Yes the windows are already closed, have you experience something
 different?

--
Ticket URL: <https://dev.haiku-os.org/ticket/8902#comment:7>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

[haiku-bugs] Re: [Haiku] #8902: Crash upon closing, after rapidly scrolling through many large photos

Other related posts: