[haiku-bugs] Re: [Haiku] #8978: 'Clicks' not set in MouseDown messages on Thinkpad TrackPoint buttons
- From: "korli" <trac@xxxxxxxxxxxx>
- Date: Wed, 30 Jan 2013 10:20:02 -0000
#8978: 'Clicks' not set in MouseDown messages on Thinkpad TrackPoint buttons
---------------------------------+----------------------------
Reporter: mks | Owner: siarzhuk
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Drivers/Mouse/PS2 | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: All
---------------------------------+----------------------------
Comment (by korli):
Since the device is detected as alps, handling happens in src/add-
ons/kernel/bus_managers/ps2/ps2_alps.cpp.
movement->clicks isn't set at all at in [http://cgit.haiku-
os.org/haiku/tree/src/add-ons/kernel/bus_managers/ps2/ps2_alps.cpp#n243
this case]. See [http://cgit.haiku-os.org/haiku/tree/src/add-
ons/kernel/bus_managers/ps2/movement_maker.cpp#n486 here] for how it
should be done.
Another problem though is that the state of cookie->movementMaker is
inconsistent (TouchpadMovement::fButtonsState for instance). A simple
solution would be to change TouchpadMovement::_UpdateButtons to public
scope, and call it after [http://cgit.haiku-os.org/haiku/tree/src/add-
ons/kernel/bus_managers/ps2/ps2_alps.cpp#n250 settings clicks].
--
Ticket URL: <http://dev.haiku-os.org/ticket/8978#comment:13>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
